-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): better missing fields ux in workflows & builder #7816
Conversation
Also update docstrings
Also update docstrings
…utFieldTemplateSafe
24d30e3
to
946a622
Compare
I think we have enough space to be a bit more verbose/grammatically correct etc. Workflow contains an unknown field "imag2e". Edit the workflow to fix the issue. |
This PR also makes some minor DX changes to some of hte workflow editor hooks. Some of the hooks throw if a node isn't found, other don't - this caught me off guard while making the changes in this PR. I renamed a couple of them, adding |
Summary
If a there was a problem with a node field that was added to the builder (e.g. it was renamed, removed from its node, or the node was removed altogether), you couldn't delete it from the builder. There was no delete button. You had to go and delete the node. Here's what it looked like:

This PR restructures the components so that we can render the error message within a form element container, with the delete button:

It also makes some improvements to the error messages for missing/unexpected fields, as seen in the above screenshot. Missing means the template has a field but the node instance does not. Unexpected means the node instance has a field that is not in the template. Hard to clearly convey these different states but this is better than before ("Unknown field: ").
In the Builder's View mode, the error looks like this:

Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1352339053382598666
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's New
copy (if doing a release after this PR)