fix(ui): clip shift-draw strokes to bbox when clip to bbox enabled #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/fix/ui/shift-draw-bbox-clip
branch
from
5b6dd08 to
c97d698
Compare
hipsterusername
approved these changes
Mar 20, 2025
psychedelicious
force-pushed
the
psyche/fix/ui/shift-draw-bbox-clip
branch
from
c97d698 to
44f6072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When holding shift to draw straight lines, if clip to bbox is enabled, we should clip to bbox.
Bug was introduced when clipping was totally disabled for shift-drawing in #7651.
Related Issues / Discussions
Closes #7809
QA Instructions
Try it out
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)