Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git-lfs for larger assets #7804

Merged
merged 12 commits into from
Mar 18, 2025
Merged

Use git-lfs for larger assets #7804

merged 12 commits into from
Mar 18, 2025

Conversation

jazzhaiku
Copy link
Collaborator

@jazzhaiku jazzhaiku commented Mar 18, 2025 •
edited
Loading

Summary

  • Integrate Git LFS to our automated Python tests in CI
  • Add stripped model files with git-lfs
  • README.md instructions to install and configure git-lfs
  • Unrelated change (skip hashing to make unit test run faster)

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added Root python-tests PRs that change python tests docs PRs that change docs labels Mar 18, 2025
@github-actions github-actions bot added the CI-CD Continuous integration / Continuous delivery label Mar 18, 2025
@jazzhaiku jazzhaiku marked this pull request as ready for review March 18, 2025 03:58
ebr
ebr approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@ebr ebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a documentation comment; otherwise LGTM, great work

Base automatically changed from stripped-models to main March 18, 2025 21:13
@psychedelicious psychedelicious merged commit d8c3af6 into main Mar 18, 2025
15 checks passed
@psychedelicious psychedelicious deleted the git-lfs branch March 18, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious left review comments

@ebr ebr ebr approved these changes

@hipsterusername hipsterusername hipsterusername approved these changes

@brandonrising brandonrising brandonrising approved these changes

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

Assignees
No one assigned
Labels
CI-CD Continuous integration / Continuous delivery docs PRs that change docs python-tests PRs that change python tests Root
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jazzhaiku @ebr @psychedelicious @hipsterusername @brandonrising