feat(app): better errors when scanning models with picklescan #7803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
brandonrising,
hipsterusername and
jazzhaiku
as code owners
github-actions
bot
added
python
brandonrising
approved these changes
Mar 18, 2025
Differentiate between malware detection and scan error.
psychedelicious
force-pushed
the
psyche/feat/app/scan-error-messages
branch
from
6232dab to
9ce574f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Differentiate between malware detection and scan error.
Also fix string formatting issue with the error messages.
Related Issues / Discussions
Investigation prompted by https://discord.com/channels/1020123559063990373/1020123559831539744/1351240891641237565
I suspect that issue is a transient scan error and not malware detection - I am able to download the model and it passes the scan.
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)