-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update opened_at to be nullable #7767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
commented
Mar 11, 2025
There is no real historical data, it's fake news. Was never actually used by OSS UI. I will update the migration to simply wipe the column. |
715db8f
to
f1f2d2c
Compare
Not sure if this is strictly required but doing it anyways.
…s, switch to the first view that has workflows
f1f2d2c
to
a15235c
Compare
|
hipsterusername
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
frontend
PRs that change frontend files
frontend-deps
PRs that change frontend dependencies
python
PRs that change python files
services
PRs that change app services
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update schema for WorkflowLibrary to allow nullable opened_at to better represent when a workflow has never been opened. Opted to make a new column versus repurposing old one, which means users will lost historical "opened_at" data but will have better data integrity going forward.
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's New
copy (if doing a release after this PR)