feat(app): less janky custom node loading #7748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
brandonrising,
hipsterusername and
jazzhaiku
as code owners
github-actions
bot
added
python
ebr
approved these changes
Mar 7, 2025
psychedelicious
force-pushed
the
psyche/feat/app/less-janky-custom-node-loading
branch
from
509d77f to
2448e48
Compare
hipsterusername
approved these changes
Mar 7, 2025
- We don't need to copy the init file. Just crawl the custom nodes dir for modules and import them all. Dunno why I didn't do this initially. - Pass the logger in as an arg. There was a race condition where if we got the logger directly in the load_custom_nodes function, the config would not have been loaded fully yet and we'd end up with the wrong custom nodes path! - Remove permissions-setting logic, I do not believe it is relevant for custom nodes - Minor cleanup of the utility
psychedelicious
force-pushed
the
psyche/feat/app/less-janky-custom-node-loading
branch
from
2448e48 to
1939ccd
Compare
|
Several node enjoyers tried the PR out and it works fine for them |
psychedelicious
deleted the
psyche/feat/app/less-janky-custom-node-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
n/a
QA Instructions
Your custom nodes should still work like they did before.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)