Do not cache image layers in CI docker build #7712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebr
requested review from
lstein,
blessedcoolant and
hipsterusername
as code owners
hipsterusername
approved these changes
Feb 28, 2025
ebr
force-pushed
the
disable-gha-docker-cache
branch
from
9762a06 to
f33bab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GHA runners run out of disk space trying to pull and store the docker build cache. Additionally, this is very slow.
This PR disables the cache. Theoretically this may increase the size of our images, but because caching has been broken anyway, this will have no impact.
Will come back and take another stab on improving caching behaviours.
Merge Plan
Merge at will.
Checklist
What's Newcopy (if doing a release after this PR)