FIX: Disable coil visibility when opening Invesalius

[unichronic]

This PR addresses the issue #867

• Updated to disable the show coil button by default on initialization
• The button state updates now only happens when all coils are toggled, avoiding unnecessary updates when toggling a single coil.

[unichronic]

@rmatsuda @tfmoraes @henrikkauppi Kindly review the PR

[unichronic]

Hey @tfmoraes can you check whether I did the right thing here?

[rmatsuda]

Hi @unichronic! Thanks for the PR and sorry for taking so long to reply.
I got the following error:

  File "C:\Users\user\repository\invesalius3\invesalius\data\visualization\coil_visualizer.py", line 133, in ShowCoil
    Publisher.sendMessage("Press show-coil button", pressed=True)
  File "C:\Users\user\repository\invesalius3\invesalius\pubsub\pub.py", line 74, in sendMessage
    Publisher.sendMessage(topicName, **msgdata)
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\publisher.py", line 216, in sendMessage
    topicObj.publish(**msgData)
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\topicobj.py", line 452, in publish
    self.__sendMessage(msgData, topicObj, msgDataSubset)
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\topicobj.py", line 482, in __sendMessage
    listener(data, self, allData)
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\listener.py", line 237, in __call__
    cb(**kwargs)
  File "C:\Users\user\repository\invesalius3\invesalius\gui\task_navigator.py", line 1799, in PressShowCoilButton
    self.OnShowCoil()
  File "C:\Users\user\repository\invesalius3\invesalius\gui\task_navigator.py", line 1822, in OnShowCoil
    Publisher.sendMessage("Show coil in viewer volume", state=pressed, coil_name=coil_name)
  File "C:\Users\user\repository\invesalius3\invesalius\pubsub\pub.py", line 74, in sendMessage
    Publisher.sendMessage(topicName, **msgdata)
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\publisher.py", line 215, in sendMessage
    topicObj = topicMgr.getOrCreateTopic(topicName)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\pubsub\core\topicmgr.py", line 207, in getOrCreateTopic
    obj = self.getTopic(name, okIfNone=True)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\wx\core.py", line 2346, in Notify
    self.notify()
  File "C:\Users\user\AppData\Local\miniconda3\envs\invesalius\Lib\site-packages\wx\core.py", line 3552, in Notify
    self.result = self.callable(*self.args, **self.kwargs)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\repository\invesalius3\app.py", line 118, in Startup2
    self.control = self.splash.control
                   ^^^^^^^^^^^^^^^^^^^
AttributeError: 'Inv3SplashScreen' object has no attribute 'control'
Traceback (most recent call last):
  File "C:\Users\user\repository\invesalius3\app.py", line 256, in OnClose
    if self.fc.IsRunning():
       ^^^^^^^
AttributeError: 'Inv3SplashScreen' object has no attribute 'fc'

[unichronic]

Sorry I closed the PR by mistake.
Hey @rmatsuda !
Have fixed the recursion that was occuring due the OnShowCoil and Show-coil button is disabled by default.

[rmatsuda]

This change needs to be reverted.

[unichronic]

Alright done. But is the change working as intended?

[rmatsuda]

Thanks for the fixes! I found one bug and I have one suggestion.

Bug: For some reason, when the preference dialog is open, the coil visualization button is set to ON, but it does not change the actual visualization of the coil.

Suggestion: When navigation starts, if the coil is available, its visualization should automatically turn ON.

[unichronic]

Can you specify the steps you took, so that I can recreate this bug because in my case even when I open Preferences its still in disabled state. Or are you talking about a different button?

[rmatsuda]

Do you have one coil created?

[unichronic]

Hey @rmatsuda I was doing a few things wrong as I am new to using coils, but anyway now I have implemented the changes.
Is it working as intended now?

[unichronic]

Hi @rmatsuda! it would be great if you could review the changes.
Also if any others have time, please take a look.
CC: @tfmoraes @paulojamorim