-
Notifications
You must be signed in to change notification settings - Fork 226
Usage with RN Web #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#335 needs testing. If working on the web is important please pull that PR (perhaps rebase it to current main...) and test it, report findings |
There is still no |
@gavrilikhin-d okay, then perhaps that PR needs additional work - if you have the PR pulled locally and web implementation is important, adding additional commits on the original PR and proposing a new + augmented PR could be the way forward |
I will try to make it work with your library, once I will fix the rest of
the RN-web issues in our project XD
…On Fri, Feb 9, 2024, 15:49 Mike Hardy ***@***.***> wrote:
@gavrilikhin-d <https://github.com/gavrilikhin-d> okay, then perhaps that
PR needs additional work - if you have the PR pulled locally and web
implementation is important, adding additional commits on the original PR
and proposing a new + augmented PR could be the way forward
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR5SO7QDIDGTCL6UJQYV3G3YSYLPNAVCNFSM6AAAAABC7V7DW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHA3TGNBTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
@mikehardy: this is causing storybook to fail to build with the same error. |
@rwitchell the path forward here is to get #335 patched up and working - I haven't had time personally, but fixing it up and pushing a new PR that works means I could merge it and this would be solved |
Heres how I fixed it with expo: For expo create a polyfill for it like so: https://gist.github.com/encloinc/91a5ca08d7be9e0ecdb5e208c3e5d9c5 and then on metro make it resolve to the polyfill if platform is web (metro.config.js): config.resolver.resolveRequest = (context, realModuleName, platform) => {
if (
realModuleName.includes("react-native-apple-authentication") &&
platform === "web"
) {
return {
filePath: path.join(
__dirname,
"polyfills/react-native-apple-authentication.js"
),
type: "sourceFile",
};
}
return context.resolveRequest(context, realModuleName, platform);
}; |
Trying to implement Universal Links and need to build my app for web.
Is there a workaround? like ignoring Apple Authentication for web build? |
Is this possible to use this library with RN Web?
Currently, there is an error:
The text was updated successfully, but these errors were encountered: