feat: providerArgs option to the push & pull command #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
requested changes
Jul 27, 2021
|
Sure! |
kazupon
reviewed
Jul 27, 2021
src/commands/pull.ts
Outdated
| @@ -97,7 +103,7 @@ export const handler = async (args: Arguments<PullOptions>): Promise<unknown> => | |||
| try { | |||
| const locales = args.locales?.split(',').filter(p => p) as Locale[] || [] | |||
| const provider = ProviderFactory(conf) | |||
| const messages = await provider.pull({ locales, dryRun, normalize, format }) | |||
| const messages = await provider.pull({ locales, dryRun, normalize, format, providerArgs }) | |||
There was a problem hiding this comment.
I think providerArgs should be parsed to object, and it should be passed to provider.
Because it's user-friendly for providers.
There was a problem hiding this comment.
Sure!
Please wait a moment.
kazupon
reviewed
Jul 27, 2021
kazupon
approved these changes
Jul 29, 2021
kazupon
pushed a commit
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #168
add providerArgs option to the push & pull command