feat: UX change in Author Page #9934
Conversation
| <div style="display: flex; align-items: center;"> | ||
| <div style="margin-right: 15px; margin-top:10px "> |
There was a problem hiding this comment.
Please avoid inline styles :)
|
Looks much better, now we just have to clean up our code a bit so we're not using inline styles. |
mekarpeles
added
the
Needs: Submitter Input
|
I will make the changes and update . Thanks : ) |
Hi, is |
|
https://github.com/internetarchive/openlibrary/blob/377be259788c040a32123ba084d70e20ce612a83/static/css/components/sort-dropper.less is probably a better place than legacy.css as sort-dropper at least deals with the sort dropper |
|
We also likely want to keep a similar consistent style to book search where it tells us how many results are being returned Proposed Author's Page |
|
@h3ri0s, did you want to make the final css changes (to avoid inline) and we can help you get this one merged in before it goes stale? Good work again and thank you for the contributions! |
h3ri0s
force-pushed
the
9928/Design/design-change-in-author-page
branch
from
35a048a to
c4846a0
Compare
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
Hi, I’ve updated the UI to place 'Sort by:' near the dropper. Thanks for the support! |
|
Nicely done! |
* fix: UX change in Author Page --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mek <[email protected]>
Closes #9928
Design Changes on the UX Author Page. Changed the position of sort dropper
Technical
The sort drop has been moved down for better visibility.
Testing
Please visit the following page ex:
/authors/OL18319A/Mark_TwainScreenshot
Stakeholders