Support covers in .zip in l_covers_0008 #9706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
the
Patch Deployed
scottbarnes
reviewed
Aug 7, 2024
| # - the naming scheme is the older scheme used by .tar files | ||
| # (eg item `l_covers_0008` instead of `olcovers9` | ||
| # - the db is not yet updated with their correct URLs | ||
| if size == "L" and 8_820_000 > value >= 8_000_000: |
There was a problem hiding this comment.
Suggested change
| if size == "L" and 8_820_000 > value >= 8_000_000: | |
| if size in ("L", "") and 8_820_000 > value >= 8_000_000: |
I am a bit unsure of this feedback as I confess I'm not entirely sure of the desired behavior. Should the zip be used for http://covers.openlibrary.org/b/id/8000001.jpg? If so, a change similar to this may be necessary, though I may simply be misunderstanding the flow and the desired goal.
There was a problem hiding this comment.
Good Q! Only the L covers have had their tars converted to zips right now; this will expand to all sizes as more of the items are fixed up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7478 . We redirected all large covers in this range to their medium counterparts because taking them out of the tars was very slow. Hank converted the tars to zips, so now we can serve them large again!
Technical
Testing
On prod, covers work! And covers like http://covers.openlibrary.org/b/id/8000001.jpg are large.
Screenshot
Stakeholders