Skip to content

Revert bad npm updates #10913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Jun 9, 2025

I experimented with enabling a GitHub option to auto-merge a PR after the checks pass. I expected this to behave like GitLab where it shows a button that let's you choose to auto-merge once the CI finished, but it seems to have caused some trouble with renovate, resulting in these two PRs being auto-merged -_- Or some other bug. These aren't ready for merging and cause the CI to fail, so rolling back.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini marked this pull request as ready for review June 9, 2025 15:20
@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 15:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts recent auto-merged dependency updates that were causing CI failures. The key changes include downgrading versions of ESLint and its associated plugins to rollback unintended updates.

Comments suppressed due to low confidence (3)

package.json:54

  • The downgrade of ESLint to version ^8.49.0 may affect linting configurations expecting newer features. Verify that this reversed version aligns with your project's linting requirements.
    "eslint": "^8.49.0",

package.json:55

  • Reverting eslint-plugin-no-jquery from 3.1.1 to 2.7.0 should be checked against any rules or configurations that depend on the plugin’s newer features.
    "eslint-plugin-no-jquery": "2.7.0",

package.json:56

  • The rollback of eslint-plugin-vue to version ^9.32.0 may have implications for Vue-related linting rules; ensure this version is fully compatible with your Vue tooling and configurations.
    "eslint-plugin-vue": "^9.32.0",

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.09%. Comparing base (e027195) to head (1fc6be2).
Report is 54 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10913      +/-   ##
==========================================
- Coverage   17.14%   17.09%   -0.05%     
==========================================
  Files          91       91              
  Lines        4981     4995      +14     
  Branches      867      869       +2     
==========================================
  Hits          854      854              
- Misses       3588     3600      +12     
- Partials      539      541       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdrini
Copy link
Collaborator Author

cdrini commented Jun 9, 2025

Auto-merging, small fix to fix CI

@cdrini cdrini changed the title Reveret bad npm updates Revert bad npm updates Jun 9, 2025
@cdrini cdrini merged commit 7468dcb into internetarchive:master Jun 9, 2025
4 checks passed
@cdrini cdrini deleted the fix/reveret-bad-updates branch June 9, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants