Fix trending page expecting different doc shape #10912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the trending page by correctly handling the different shapes of the "editions" document. The changes include:
- Supporting both dictionary and list forms of the "editions" value.
- Updating the logic to select the first edition only when the document type is 'solr_edition' and editions are present.
|
Auto-merging, small addendum to #10882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #10882
Technical
I thought there was a reason I ended up using the
get_docsmethod :P SearchResultItems I believe expected the return of this method. Updated it to handle both that and a direct dict from solr.Testing
Tested author pages, trending pages, and search result pages; all SearchResultItem's now show up correctly
Screenshot
Stakeholders