Don't save number of pages 0 from Amazon

[cdrini]

Closes #10868 . Small fix, just check if 0.

Technical

Testing

Tested via unit tests; couldn't test this otherwise since the already-coerced metadata record is stored in the affiliate server cache, so can't have it be re-processed by my new code.

Screenshot

Stakeholders

[Copilot]

Pull Request Overview

This PR ensures that books with zero pages from Amazon don’t include a number_of_pages field in the serialized output.

• Add a unit test to verify pages count of 0 is omitted.
• Update serialize to skip number_of_pages when its value is zero.
• Adjust existing test to no longer expect an empty number_of_pages key.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openlibrary/tests/core/test_vendors.py	Add test for zero pages and remove outdated expectation
openlibrary/core/vendors.py	Change serialization to omit number_of_pages when zero

Comments suppressed due to low confidence (1)

openlibrary/core/vendors.py:323

• Relying on truthiness to exclude zero works for numeric values but could include '0' if display_value were ever a string. Consider explicitly checking edition_info.pages_count.display_value > 0.

and edition_info.pages_count.display_value

[Copilot]

[nitpick] The dictionary-unpacking with **({ ... }) adds complexity. Consider building the number_of_pages key directly in the surrounding dict (e.g., using a single conditional assignment) to improve readability.

Suggested change

	**(
	{'number_of_pages': edition_info.pages_count.display_value}
	if (
	edition_info
	and edition_info.pages_count
	# Note this intentionally excludes 0
	and edition_info.pages_count.display_value
	)
	else {}
	'number_of_pages': (
	edition_info.pages_count.display_value
	if (
	edition_info
	and edition_info.pages_count
	# Note this intentionally excludes 0
	and edition_info.pages_count.display_value
	)
	else None