Skip to content

Remove "LibraryLink" links from book pages #10884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sai-krishna-kotha
Copy link
Contributor

Closes #10859

Description

This PR fixes a UI issue by commenting out the <li> tag that displays a link to a public inactive API. This prevents users from seeing or clicking on a broken or deprecated link.

Technical

  • Commented out the <li> element in the relevant template to hide the inactive API link.
  • No functional changes beyond UI adjustment.

Testing

  • Verified locally that the link is no longer visible in the UI.
  • Checked that no other UI elements are affected.

Screenshot

Screenshot from 2025-06-02 17-17-32

Stakeholders

@mekarpeles

@jimchamp jimchamp assigned jimchamp and unassigned mekarpeles Jun 2, 2025
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Jun 2, 2025
@github-actions github-actions bot removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Jun 2, 2025
@mekarpeles mekarpeles merged commit b10d0a9 into internetarchive:master Jun 2, 2025
4 checks passed
@jimchamp jimchamp changed the title fix(#10859): commented the Library.linkd Remove "LibraryLink" links from book pages Jun 2, 2025
@jimchamp
Copy link
Collaborator

jimchamp commented Jun 2, 2025

Thanks, @sai-krishna-kotha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate "LibraryLink" on books page; links are broken
3 participants