Skip to content

add a link to merged works #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

BearSunny
Copy link
Contributor

Closes #10714

This PR achieve to link each merge request listed to the resultant work.

Technical

I only added a link to $review_url by setting <a href="$review_url" class="mr-title-link">. This should create a link to the resultant work for now. If there's anything more that should be done, please leave a feedback. Thank you!

Testing

Screenshot

Screenshot 2025-05-16 104300

Stakeholders

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BearSunny! I noticed an issue with the requirements, and have suggested a change that should correct the problem (some more background information is included in the comment with the suggestion).

Could you test this change, and commit it if it works? You can follow the steps outlined here to populate your local development instance with a few merge requests (some open, some closed).

@BearSunny
Copy link
Contributor Author

Thank you for your feedback @jimchamp! I have tested the change and it works perfectly so now only closed merges are linked with the resultant works. I have also committed the change.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 18, 2025
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BearSunny! Have confirmed that the links are appearing only for closed merge requests.

@jimchamp jimchamp merged commit 0f25ff0 into internetarchive:master May 20, 2025
4 checks passed
@jimchamp
Copy link
Collaborator

Although the links are present on closed merge requests, these pages are only accessible for patrons with the following privileges:

  • librarian
  • super-librarian
  • admin

I think that this is fine for now, as the merge request table isn't navigable from the UI unless the patron is a member of any of these groups. When/if we expose this table to all patrons, we'll probably want to make the following changes:

  1. Remove the merge buttons from merge UIs for patrons who click this new link. We can probably use a query parameter for this.
  2. Lift the access restrictions to the author and work merge pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Response Issues which require feedback from lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to each merged work in the closed community edits list.
2 participants