-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Harvard University and alpha sort MARC sources #10771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a more user-friendly label for Harvard and reorders MARC source mappings in sources.html
for consistency
- Updates the label for
harvard_bibliographic_metadata
to “Harvard University” - Inserts new MARC source entries and alphabetizes the keys
- Refactors string concatenation to f-strings for URLs and links
Comments suppressed due to low confidence (2)
openlibrary/templates/history/sources.html:5
- Add or update a test to verify that
harvard_bibliographic_metadata
maps to “Harvard University” in the rendered source list, ensuring the new label appears correctly.
"harvard_bibliographic_metadata": "Harvard University",
openlibrary/templates/history/sources.html:5
- [nitpick] Inconsistent indentation detected (a tab is used on this line). Convert all leading tabs to spaces to match the surrounding entries.
"harvard_bibliographic_metadata": "Harvard University",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Copilot <[email protected]>
@jimchamp uh, the AI suggested change was crap though. It wasn't in alphabetical order. I wasted time checking it, c an we revert it? |
Looks like f-string literals cannot be used in our templates, and book pages are not rendering after these updates. Will open a PR reverting those changes shortly. |
Closes #
Changes the source text from "harvard_bibliographic_metadata record" to "Harvard University record"
Example record: https://openlibrary.org/books/OL59082038M/Krugi
and alpha sorts the keys for organisation.
Technical
Testing
Screenshot
Stakeholders