Add sort options to languages page #10751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
feature/language-page-sorting
branch
from
708b8f2 to
d49ac95
Compare
cdrini
force-pushed
the
feature/language-page-sorting
branch
from
d49ac95 to
88c1120
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds sort options for the languages page so users can easily filter languages based on ebook counts and other criteria.
- Refactored sort options template logic to support nested sort options and conditional admin-only options.
- Updated languages rendering and backend sorting in the worksearch plugin to handle new sort parameters.
- Modified internationalization messages to match the updated sort option labels.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openlibrary/templates/search/sort_options.html | Replaced the old sort_option_names dictionary and helper with a new get_selected_sort_option function and adjusted the admin check for the title sort option. |
| openlibrary/templates/languages/index.html | Integrated the new sort options template for the languages page and adjusted link formatting in the language list. |
| openlibrary/plugins/worksearch/languages.py | Added a new sort parameter for top languages, included marc_code and ebook edition count, and validated sort inputs. |
| openlibrary/i18n/messages.pot | Updated msgid strings to reflect new sort option names and their order. |
Comments suppressed due to low confidence (1)
openlibrary/i18n/messages.pot:7023
- [nitpick] The msgid strings have been reordered and renamed to match new sort option labels; please verify that the translation mappings correspond correctly to the intended UI labels to avoid inconsistencies for translators and end users.
msgid "Most Recent"
Comment on lines
+9
to
18
| selected = option['sort'] == selected_sort or option.get('selected') | ||
| if selected: | ||
| return option | ||
|
|
||
| selected_sort_name = get_selected_sort_name(selected_sort, default_sort, sort_option_names) | ||
| sub_sorts = option.get('sub_sorts', []) | ||
| if sub_sorts: | ||
| selected_sub_sort = get_selected_sort_option(sub_sorts, selected_sort) | ||
| if selected_sub_sort: | ||
| return selected_sub_sort | ||
|
|
There was a problem hiding this comment.
[nitpick] The function returns immediately when a top-level option is marked as selected, which prevents checking for a more specific match among sub_sorts. Consider revising the logic order to ensure that nested sub_sort options are considered appropriately when available.
Copilot uses AI. Check for mistakes.
mekarpeles
added
the
Priority: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to be able to easily find which languages have the most ebooks.
Technical
Testing
Screenshot
Stakeholders