Remove/move some dead methods #10743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by removing outdated/unused methods from the home module and relocating the implementation of format_work_data to the code module.
- Removed dead methods (format_list_editions, pick_best_edition, and format_work_data) from home.py.
- Added an updated version of format_work_data to code.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openlibrary/plugins/openlibrary/home.py | Removed unused/dead methods and associated memoization logic. |
| openlibrary/plugins/openlibrary/code.py | Replaced the removed format_work_data import with a new definition. |
Comments suppressed due to low confidence (1)
openlibrary/plugins/openlibrary/code.py:292
- [nitpick] The use of 'key' as the loop variable in the list comprehension shadows the previously defined variable 'key'. Consider renaming it (e.g., to 'author_key') to improve clarity.
for key, name in zip(work['author_key'], work['author_name'])
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor.
Technical
Testing
Screenshot
Stakeholders