-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fixed Preview button being cropped #10698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Preview button being cropped #10698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; not testing this since testing is down right now, but the fix seems reasonable. Thank you @Jimmykhangnguyen !
On second thought , I'll wait for testing just to make sure this one is working before giving it a merge 👍 |
Also this needs to be rebased against latest master to fix the failing test 👍 |
Thanks! Yeah I think it wouldn't hurt to run it through the test, I'll rebase it and tag you in once I'm done! |
e04ee85
to
c828850
Compare
@cdrini I think it looks good now! Thanks for the review! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10698 +/- ##
==========================================
+ Coverage 17.27% 17.34% +0.07%
==========================================
Files 87 90 +3
Lines 4845 4923 +78
Branches 860 859 -1
==========================================
+ Hits 837 854 +17
- Misses 3477 3536 +59
- Partials 531 533 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @Jimmykhangnguyen ! We decided to make the font-size a bit smaller since it was causing the cover to become a bit larger when we set overflow:visible
. We also remove overflow: visible
, since that's the default! So we don't need to specify it.
Closes #10667
This PR attempts to fix the issue where the "Preview" button in the Author page was cropped off.
Technical
After going through the code, I figured a single CSS change to
openlibrary\static\css\components\search-result-item.less
should do the trick and prevent the "Preview" button from being clipped off.What I did was essentially changed the
overflow
attribute of.bookcover
fromhidden
tovisible
.Testing
Screenshot
Before:

After

Stakeholders
@RayBB