Filter carousels to appear in user's language #10691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
requested changes
Apr 24, 2025
cdrini
added
the
Needs: Submitter Input
Remove the public status of get_marc21_language as I am instead using convert_iso_to_marc (which is now marked as public)
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
Switched the user_lang_only parameters on the carousels on the homepage to True
Switched to convert_iso_to_marc
Switched to convert_iso_to_marc
cdrini
requested changes
May 8, 2025
cdrini
added
the
Needs: Submitter Input
Co-authored-by: Drini Cami <[email protected]>
Co-authored-by: Drini Cami <[email protected]>
github-actions
bot
removed
the
Needs: Submitter Input
Moved the query logic up in the file
convert_iso_to_marc didn't seem to accept get_lang() or 'en' as an argument, It wanted a single string, so I moved that logic to the web_lang variable
convert_iso_to_marc didn't seem to accept get_lang() or 'en' as an argument, It wanted a single string, so I moved that logic to the web_lang variable
cdrini
reviewed
May 9, 2025
Otherwise carousels will appear largely empty. Longer term we want to give a UI control.
cdrini
changed the title
cdrini
approved these changes
May 12, 2025
There was a problem hiding this comment.
Ok, lgtm! We ended up adding a limit to only filter if the language is in a list of many languages, because otherwise we were seeing a lot of empty carousels. Long term we want to create a UI option for this, though.
But otherwise, here's the homepage looking great in French!
Note a few of these carousels might look non-French, but it's actually this bug: #10742 .
Also CC @seabelis , in case this causes some patron confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10562 is no longer blocked. This PR adds the functionality to filter a carousel based on the users language.
Closes #10562
This PR adds the functionality to filter a carousel based on the users language.
Technical
Right now, for all of the carousels, user_lang_only=False, but it gives the option to add this filter in the future.
I used the get_marc21_lang function as it took a 2 letter language abbreviation and makes it 3 letters (ex. en -> eng)
Testing
docker compose run --rm home make test
As mentioned in the issue, this is hard to test locally. However, I was able to test it locally by flipping user_lang_only=True in the QueryCarousel.html parameters in order to see the changes. Then I looked at the "you might also like" and "also by this author" carousels to see if it was filtering by language. Normally, without this change (or if user_lang_only= false) if I go to the "you might also like" carousel of Robinson Crusoe it suggests the German version of Alice in Wonderland. However, as the screenshots show, it no longer does that because the carousel is filtering on language.
Screenshot
Stakeholders
@cdrini