Add option to filter reading stats by year read #10679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
requested changes
Apr 23, 2025
There was a problem hiding this comment.
Nice work @RedJade26 ! A few fixes / comments for you, and one small change in requirements. Let me know if you have any questions!
cdrini
added
the
Needs: Submitter Input
Co-authored-by: Drini Cami <[email protected]>
Co-authored-by: Drini Cami <[email protected]>
github-actions
bot
removed
the
Needs: Submitter Input
Co-authored-by: Drini Cami <[email protected]>
Co-authored-by: Drini Cami <[email protected]>
cdrini
reviewed
Apr 24, 2025
cdrini
changed the title
cdrini
approved these changes
Apr 24, 2025
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filter by year dropdown to the "already read" stats page. Fixing a previous PR by using year_breadcrumb_select.html
Closes #10648
Adding dropdown to readinglog stats page so the user can be filtered by yearTechnical
Edited the stats GET request in the mybooks.py file to also process the year that each book was read. I also edited the readinglog_stats.html template page to add in the year drop down and properly change the URL endpoint to filter the books.
Testing
docker compose run --rm home make test
tested on my localhost -screenshots below
Screenshot
Stakeholders
@cdrini