Change and add entries to language_map to handle the corrected Burmese 3-character language code #10671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 3-character language code
hornc
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
This looks good to me.
It conforms to the LOC language codes where bur is recognised https://www.loc.gov/marc/languages/language_code.html#b
but mya is not: https://www.loc.gov/marc/languages/language_code.html#m
OL currently uses the LOC codes rather than ISO 639-3 , but it should be able to recognise the mya code and convert it, as this PR does.
QuangPhung15
deleted the
10519/fix/Change_Burmese_language_code_from_mya_to_bur
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required #10519
This PR changed the 3-character code of Burmese from
myatoburbecause OL does not accept import with language codemya."error": "invalid language code: 'mya'"This fix will help not only import 4k books from the Ebook Foundation but also all the future books imported in OL.
Technical
Testing
Run the tests.
Screenshot
This is just an example book import with
burlanguage code (not an actual book).Stakeholders
@mekarpeles