Restore MIT Press carousel #10660
Merged
Restore MIT Press carousel #10660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10659
Restores Authors Alliance / MIT Press carousel by adding sorting criteria. Without a value for
sorts, the/advancedsearch.phprequest ended withsort[]=. Such requests resulted in400s.All other homepage
custom_ia_carouselsuse["lending___last_browse desc"]as the sorts value. Adding the same to the MIT Press carousel fixed the issue. I'm not sure if this is exactly how we want to sort these books --- reviewers should feel free to suggest another way if they are so moved.Technical
Testing
Screenshot
Screenshot from testing environment
Stakeholders