Add new carousel read button definition #10630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10628
Fixes squared corners and improper padding of read buttons in carousels
Technical
Instead of using the
isCarouselflag inmacros/ReadButton.htmlto toggle the rendering of the<details>element within the attached-dropdown read button, instead determine whether to generate the attached-dropdown read button at all or instead a "vanilla" read button that doesn't have the<details>element or any dropper-related class tags.Testing
Screenshot
Stakeholders
@mekarpeles - Let me know if this works! Looks alright to me with the primitive testing method I have available