Fix global lists erroring when rendering #10607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
fix/global-list-rendering
branch
from
4684f81 to
1d8c9cd
Compare
cdrini
force-pushed
the
fix/global-list-rendering
branch
from
1d8c9cd to
f9f4061
Compare
cdrini
added
the
Patch Deployed
|
Patch deploying this, since the fix is rather low risk, and it's blocking me from sharing something on OL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global lists failing to render at all on prod.
Technical
Testing
Before: https://openlibrary.org/lists/OL286201L/International_Booker_Prize_2025_LonglistPatch deployed, so no longer erroring.After: https://testing.openlibrary.org/lists/OL286201L/International_Booker_Prize_2025_Longlist
Screenshot
Before:
After:
Stakeholders