guard against web.ctx.features AttributeError in cache contexts #10526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard against the `features.is_enabled` check failures by ensuring `web.ctx` is hydrated in contexts where memcached is recomputed in a separate thread by using `delegate.fakeload()` to hydrate `web.ctx`.
for more information, see https://pre-commit.ci
mekarpeles
added
the
Patch Deployed
cdrini
removed
the
Patch Deployed
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@cdrini approved via ABC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against the
features.is_enabledfailures in cache (when recomputed in threads), checkhasattr(web, 'ctx')valuefordebugfeature.Closes #10341
Technical
Tested on mek / staging.
See technical notes here
Testing
Confirmed debug page still works (may require a few attempts to trigger solr timeout, requires correct debug key) https://openlibrary.org/search?q=language:eng&debug=xxx
Screenshot
Stakeholders