Skip to content

cron wrapper follow-up tasks #10448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Feb 12, 2025

Closes #10447

Does the following:

  • References to dns are updated to dsn in the wrapper script
  • Updates sentry_sdk.init to use correct traces_sample_rate parameter
  • Adds executable permissions and shebangs to scripts that were missing either
  • Removes cron_watcher action and script

Each file that was missing a shebang was also missing executable permissions.

Special Deployment Instructions

The configuration file was also updated. Be sure to merge those changes along with these.

Technical

Testing

Screenshot

Stakeholders

Changes `dns` references to `dsn` (data source name).
Updates incorrect `sentry_sdk.init` keyword parameter.
@jimchamp jimchamp added the Needs: Special Deploy This PR will need a non-standard deploy to production label Feb 12, 2025
@mekarpeles mekarpeles merged commit 208ecfe into internetarchive:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron_wrapper.py follow-up tasks
2 participants