List search only finds exact matches: Switch to use Solr

[jessamynwest]

Blocked by: #2609

Expanding on #364 Improve and expand list searching to search inside list titles.

A List search result is only given if the exact, full name of a list is used in the search. Searching on words that are only part of a list name returns "No results found."

Relevant url?

https://openlibrary.org/search/lists

Steps to Reproduce

1. Go to ... https://openlibrary.org/search/lists
2. Do ... enter a partial list name, for example, https://openlibrary.org/search/lists?q=banned

• Actual: only exact matches returned
• Expected: any list containing search term should be returned

Proposal & Constraints

We can now replace lists search with solr-backed list search since lists are now in solr! To do so, we will need to:

• add a new SearchScheme for lists; see the e.g. AuthorSearchScheme as an example.
• Update the /search/lists controller to now do a solr search instead

  openlibrary/openlibrary/plugins/worksearch/code.py

  Lines 574 to 597 in 4f0c3c7

  	class list_search(delegate.page):
  	path = '/search/lists'
  	def GET(self):
  	i = web.input(q='', offset='0', limit='10')
  	lists = self.get_results(i.q, i.offset, i.limit)
  	return render_template('search/lists.tmpl', q=i.q, lists=lists)
  	def get_results(self, q, offset=0, limit=100):
  	if 'env' not in web.ctx:
  	delegate.fakeload()
  	keys = web.ctx.site.things(
  	{
  	"type": "/type/list",
  	"name~": q,
  	"limit": int(limit),
  	"offset": int(offset),
  	}
  	)
  	return web.ctx.site.get_many(keys)

  . Follow the pattern from authors:

  openlibrary/openlibrary/plugins/worksearch/code.py

  Lines 664 to 674 in 4f0c3c7

  	def get_results(self, q, offset=0, limit=100, fields='*', sort=''):
  	resp = run_solr_query(
  	AuthorSearchScheme(),
  	{'q': q},
  	offset=offset,
  	rows=limit,
  	fields=fields,
  	sort=sort,
  	)
  	return resp

  .
• You might need to make some changes to https://github.com/internetarchive/openlibrary/blob/097f52e86c3bbbb65a31c4bc46000d259e30c504/openlibrary/templates/search/lists.html as well.

Stakeholders

@cdrini @seabelis @el4ctr0n

[xayhewalo]

@cdrini @tfmorris I'm assuming list search is a Solr feature? Will that be apart of the reindex?

[BrittanyBunk]

You're asking for a search bar for a list when clicking on it? This really is part of a bigger issue, where when clicking on anything - authors, works, etc. - it's not possible to alphabetize or search. I mentioned it on #2741 too, but for authors. I believe I also created a github issue for works/editions, but maybe someone else could find that #.

[tfmorris]

@guyjeangilles It would be a combination of UI plus Solr. It's a new feature which would not fall naturally out of the general Solr upgrade project.