Skip to content

[SYCL] Fix lifetime bug in root group unit tests #19082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL] Fix lifetime bug in root group unit tests #19082

wants to merge 1 commit into from

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Jun 20, 2025

Changes the MockDeviceImage and MockDeviceImageArray to static variables so that they're not created in each test case. Relates to #19068 and #19074. Fixes #18892.

@0x12CC 0x12CC requested a review from a team as a code owner June 20, 2025 20:06
@0x12CC 0x12CC requested a review from slawekptak June 20, 2025 20:06
@0x12CC 0x12CC temporarily deployed to WindowsCILock June 20, 2025 20:06 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock June 20, 2025 20:28 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock June 20, 2025 20:28 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RootGroupTests.ValidNumWorkGroupsQuery failed on unrelated patch with Exception Code: 0xE06D7363
1 participant
@0x12CC