[UR][SYCL] Introduce UR api to set kernel args + launch in one call. #18764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
igchor
reviewed
Jun 2, 2025
unified-runtime/source/adapters/level_zero/v2/queue_immediate_in_order.cpp
Outdated
Show resolved
Hide resolved
| @@ -1036,6 +1037,77 @@ ur_result_t ur_queue_immediate_in_order_t::enqueueCommandBufferExp( | |||
| return UR_RESULT_SUCCESS; | |||
| } | |||
|
|
|||
| ur_result_t ur_queue_immediate_in_order_t::enqueueKernelLaunchWithArgsExp( | |||
There was a problem hiding this comment.
I think it would be better to move most of the implementation to command_manager.cpp. If we do that, we can:
- avoid taking kernel->mutex twice (commandListLocked->appendKernelLaunch does that internally)
- avoid creating pending_allocations vector - this was only needed for urKernelSetArgMemObj where we need to delay calling zeKernelSetArgumentValue until actual kernel submission. Now, we can just call it directly.
I'm okay doing this myself, though, after this PR is merged. Just wanted to note it somewhere.
There was a problem hiding this comment.
I think I ended up doing this as part of a conflict resolution recently
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
b91b20e to
76612c5
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
reviewed
Jun 3, 2025
| @@ -2405,22 +2496,34 @@ static ur_result_t SetKernelParamsAndLaunch( | |||
| : Empty); | |||
| } | |||
|
|
|||
| std::vector<ur_exp_kernel_arg_properties_t> UrArgs; | |||
There was a problem hiding this comment.
Would it be possible to keep this vector inside of the queue object so that we don't allocate it (potentially multiple times if there's a lot of arguments) for every kernel launch?
We have a similar mechanism in L0v2 adapter here:
https://github.com/oneapi-src/unified-runtime/blob/main/source/adapters/level_zero/v2/command_list_manager.hpp#L177
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
76612c5 to
1554457
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
7a2f91c to
6123fa6
Compare
aarongreig
force-pushed
the
aaron/enqueueKernelWithArgs
branch
from
6123fa6 to
cebad02
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.