[DeviceMSAN] Enable origin tracking #18693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yingcong-wu
reviewed
Jun 17, 2025
zhaomaosu
reviewed
Jun 17, 2025
unified-runtime/source/loader/layers/sanitizer/sanitizer_common/sanitizer_stackdepot.hpp
Show resolved
Hide resolved
Fixed, cpu device was enabled as well. |
|
Kindly ping @intel/unified-runtime-reviewers. Thanks! |
zhaomaosu
reviewed
Jun 20, 2025
zhaomaosu
approved these changes
Jun 20, 2025
aarongreig
reviewed
Jun 20, 2025
unified-runtime/source/loader/layers/sanitizer/sanitizer_common/sanitizer_utils.hpp
Show resolved
Hide resolved
aarongreig
approved these changes
Jun 20, 2025
AllanZyne
commented
Jun 20, 2025
| @@ -63,38 +59,11 @@ ur_result_t EnqueueMemCopyRectHelper( | |||
| // loop call 2D memory copy function to implement it. | |||
| for (size_t i = 0; i < Region.depth; i++) { | |||
| ur_event_handle_t NewEvent{}; | |||
| UR_CALL(getContext()->urDdiTable.Enqueue.pfnUSMMemcpy2D( | |||
| UR_CALL(msan::urEnqueueUSMMemcpy2D( | |||
There was a problem hiding this comment.
Just comment: using APIs from msan_ddi so that the shadow and origin can be copied automatically
mdtoguchi
reviewed
Jun 20, 2025
clang/lib/Driver/SanitizerArgs.cpp
Outdated
| @@ -1317,6 +1317,14 @@ void SanitizerArgs::addArgs(const ToolChain &TC, const llvm::opt::ArgList &Args, | |||
|
|
|||
| CmdArgs.push_back("-mllvm"); | |||
| CmdArgs.push_back("-msan-poison-stack-with-call=1"); | |||
|
|
|||
| if (MsanTrackOrigins) { | |||
| assert(MsanTrackOrigins == 1 && | |||
There was a problem hiding this comment.
An assertion is pretty harsh for an invalid argument to a command line option. Can this be changed to use err_drv_argument_only_allowed_with instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable origin tracking for host/shared/device USM, which can provide the more debug information about the detected uninitialized memory.