Skip to content

[NFC][SYCL] Don't use get_platform_info outside platform_impl #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

[NFC][SYCL] Don't use get_platform_info outside platform_impl #18291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sycl/source/detail/allowlist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <detail/config.hpp>
#include <detail/device_impl.hpp>
#include <detail/device_info.hpp>
#include <detail/platform_info.hpp>
#include <sycl/backend_types.hpp>

#include <algorithm>
Expand Down Expand Up @@ -387,12 +386,10 @@ void applyAllowList(std::vector<ur_device_handle_t> &UrDevices,
}
// get PlatformVersion value and put it to DeviceDesc
DeviceDesc.emplace(PlatformVersionKeyName,
sycl::detail::get_platform_info<info::platform::version>(
UrPlatform, Adapter));
PlatformImpl.get_info<info::platform::version>());
// get PlatformName value and put it to DeviceDesc
DeviceDesc.emplace(PlatformNameKeyName,
sycl::detail::get_platform_info<info::platform::name>(
UrPlatform, Adapter));
PlatformImpl.get_info<info::platform::name>());

int InsertIDx = 0;
for (ur_device_handle_t Device : UrDevices) {
Expand Down