[SYCL] Remove deprecated sycl::host_ptr/sycl::device_ptr #13240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have been deprecated in intel#7680 more than a year ago.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
deprecated-host_device_ptr
branch
from
acf739d to
e2250a9
Compare
againull
approved these changes
Apr 1, 2024
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
reviewed
Apr 2, 2024
There was a problem hiding this comment.
FYI @GarveyJoe: note that we are removing the deprecated sycl::host_ptr and sycl::device_ptr aliases. If there is any code using these, it should be migrated to use sycl::ext::intel::device_ptr, etc.
sycl/doc/extensions/supported/sycl_ext_intel_usm_address_spaces.asciidoc
Outdated
Show resolved
Hide resolved
…s.asciidoc Co-authored-by: Greg Lueck <[email protected]>
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
approved these changes
Apr 2, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
is unrelated, fix is in #13242. |
aelovikov-intel
added
the
abi-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have been deprecated in #7680 more than a year ago.