Skip to content

Fix "off by one" error in RemoveMask pass #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Fix "off by one" error in RemoveMask pass #4194

merged 2 commits into from
May 14, 2025

Conversation

etiotto
Copy link
Contributor

@etiotto etiotto commented May 14, 2025

Fixes #4186, #4187.

Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
@etiotto etiotto changed the title Fix issue #4142 Fix "off by one" error in RemoveMask pass May 14, 2025
@etiotto etiotto marked this pull request as ready for review May 14, 2025 13:57
@etiotto etiotto enabled auto-merge (squash) May 14, 2025 13:57
@etiotto etiotto merged commit e07bc13 into main May 14, 2025
15 checks passed
@etiotto etiotto deleted the etiotto.fix4142.1 branch May 14, 2025 14:44
whitneywhtsang added a commit that referenced this pull request May 14, 2025
@whitneywhtsang
Copy link
Contributor

This PR causes a performance degradation on gemm-tensor-of-ptr, created #4206 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants