-
Notifications
You must be signed in to change notification settings - Fork 62
Don't build SPIRV translator tools #4153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anatoly Myachev <[email protected]>
third_party/intel/cmake/tools.patch
Outdated
|
||
|
||
add_subdirectory(lib/SPIRV) | ||
-add_subdirectory(tools/llvm-spirv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disables building the executable, the library we need is still built.
Using patching is too hacky. Can we update the setup.py to just build the components on demand not to build |
I agree
I don't know how to do this on our side but can imagine how to do it on SPIRV-LLVM Translator side. |
The Triton python intel-xpu-backend-for-triton/setup.py Line 529 in 0d81235
Maybe we can change this. Or maybe use this CMake options https://cmake.org/cmake/help/latest/prop_tgt/EXCLUDE_FROM_ALL.html |
thanks @chengjunlu! Will try |
This reverts commit 4af62cf.
Signed-off-by: Anatoly Myachev <[email protected]>
@chengjunlu done |
This file is one of the last linked files, after which the build Triton in PyTorch breaks due to memory overuse:
PyTorch CI: https://github.com/pytorch/pytorch/actions/runs/14910976516/job/41910654750?pr=153096
How much do we need it?
Relates to #3521