[Flex Attention] Apply patch from pytorch#143553 instead of using fork #3945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
pbchekin
approved these changes
Apr 16, 2025
anmyachev
commented
Apr 16, 2025
| @@ -18,3 +18,4 @@ cd "$REPO_ROOT" | |||
|
|
|||
| # curl -sSL https://github.com/pytorch/pytorch/pull/126516.diff | git apply - | |||
| git apply "${SCRIPT_DIR}/pytorch_fp64.patch" | |||
| curl -sSL https://github.com/pytorch/pytorch/pull/143553.diff | git apply --exclude=test/inductor/test_flex_attention.py --exclude=test/inductor/test_flex_decoding.py - | |||
There was a problem hiding this comment.
The test files contain a lot of changes at the moment. Since the changes from them are not directly needed to run the benchmarks, I excluded them (to simplify).
|
@whitneywhtsang do you want to merge #3943 before? |
It is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.