Skip to content

[benchmarks][ci] Initial integration of sglang kernels to benchmarks #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LiyangLingIntel
Copy link
Contributor

@LiyangLingIntel LiyangLingIntel commented Mar 31, 2025

The initial enabling for sglang benchmarks.
Include sglang prefill/decode/extended attention in third-party benchmark.

@LiyangLingIntel LiyangLingIntel self-assigned this Mar 31, 2025
@LiyangLingIntel LiyangLingIntel force-pushed the liyang/init_sglang_benchmark branch 3 times, most recently from b43b5e2 to bbd10a8 Compare April 9, 2025 02:34
@LiyangLingIntel LiyangLingIntel force-pushed the liyang/init_sglang_benchmark branch 2 times, most recently from 34e464a to 29e2711 Compare April 10, 2025 06:07
@LiyangLingIntel LiyangLingIntel marked this pull request as ready for review April 10, 2025 07:47
@LiyangLingIntel
Copy link
Contributor Author

Benchmark is still blocked by #3748, #3749.
Let's merge this PR when the blocking issues are resolved with the new agama release, expect in late April.

Port prefill attn and decode attn from sglang

Add validation

temp add extend attention

disable debug ir dump

Update three stage attention benchmark

Add sglang kernel benchmark to action

use 1e-3 atol

remove sglang benchmark from triton-benchmarks

Fix setup bdist_wheel

Add sglang to thirdparty test
LiyangLingIntel and others added 3 commits April 15, 2025 08:12
Remove sglang from tests

Fix CI

Address review comments

Integrate sglang prefill/decode/extend kernel to benchmarks

Port prefill attn and decode attn from sglang

Add validation

temp add extend attention

disable debug ir dump

Update three stage attention benchmark

Add sglang kernel benchmark to action

use 1e-3 atol

remove sglang benchmark from triton-benchmarks

Fix setup bdist_wheel

Add sglang to thirdparty test

Address review comments

Remove sglang from tests

Adjust params term

Adjust tflops computation
@LiyangLingIntel LiyangLingIntel force-pushed the liyang/init_sglang_benchmark branch from 9651ebe to e609f5d Compare April 15, 2025 08:14
@etiotto etiotto marked this pull request as draft April 17, 2025 14:27
@etiotto
Copy link
Contributor

etiotto commented Apr 24, 2025

@LiyangLingIntel the test are passing. Is this PR still going to wait on #3748 and #3749 ?

@LiyangLingIntel
Copy link
Contributor Author

@LiyangLingIntel the test are passing. Is this PR still going to wait on #3748 and #3749 ?

@etiotto Yes, these 2 depend on the new agama release.
The target workflow is Triton Third-party benchmark, it is not included in CI and scheduled once per day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants