Skip to content

workflows: rework, trivy & publish #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Aug 25, 2023

Fixes: #882

@tkatila tkatila requested review from bart0sh, kad and mythi as code owners August 25, 2023 13:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #1511 (49f1b0b) into main (6683d5b) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 49f1b0b differs from pull request most recent head f4b60de. Consider uploading reports for the commit f4b60de to get more accurate results

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files          43       43           
  Lines        4884     4884           
=======================================
  Hits         2444     2444           
  Misses       2301     2301           
  Partials      139      139           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tkatila tkatila force-pushed the workflows/rework-trivy-publish branch from 60f7581 to ebbd1a0 Compare August 28, 2023 14:11
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work, thanks! two small suggestions and maybe then squash for merging

could add "Fixes: #882"

* introduce trivy scanning
* add new 'release' workflow that publishes images
* split 'ci' flow into two: 'ci' & 'devel'
* 'devel' flow publishes images
* workflows share common parts (build, e2e, publish etc.)

Signed-off-by: Tuomas Katila <[email protected]>
@tkatila tkatila force-pushed the workflows/rework-trivy-publish branch from f4b60de to ff32f36 Compare August 30, 2023 12:52
@mythi mythi merged commit 17d923a into intel:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run e2e jobs only after all CI checks pass
3 participants