Skip to content

test(package_list_parser): Improve test coverage for package_list #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JigyasuRajput
Copy link
Contributor

Description:

FIxes #4875

This PR enhances the test coverage for package_list_parser.py by adding unit tests for its core functions.

Changes:

  • Added tests for parse_list, add_vendor, parse_data, and check_file functions.
  • Included various package manager scenarios (dpkg, rpm, pacman, pip).
  • Added edge case tests for handling missing/malformed data.
  • Improved assertions to ensure correctness of parsed package lists.

Why this is needed:

  • Improves test coverage and ensures correctness.
  • Catches potential issues with different package manager formats.

Testing:

All test cases passed.

@JigyasuRajput JigyasuRajput changed the title test(package_list_parser): Improve test coverage for package_list_parser test(package_list_parser): Improve test coverage for package_list Mar 6, 2025
@JigyasuRajput
Copy link
Contributor Author

Hey!
I think the gitlint can be fixed, but the another test failure usually happens when the network isn’t reachable or the connection isn’t properly routed. Maybe re-running CI would fix it? (but I'm not sure for this one)

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok to merge, but I'm going to go ahead and update the branch for safety since it's pretty old. I'll set it to merge if the tests pass.

@terriko terriko enabled auto-merge (squash) April 14, 2025 17:28
@terriko terriko merged commit e36aabe into intel:main Apr 14, 2025
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Improve Test Coverage for package_list_parser.py
2 participants