Skip to content

feat(checker): Detect Python 3.12.x #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

captainreality
Copy link
Contributor

Add checker detection of Python 3.12.x.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like black has a formatting nit for you. You likely need to run black test/test_data/python.py and then check in and push the updated file to this PR.

Linter docs are here in case you haven't done this before: https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters

@terriko terriko changed the title feat(checker): Detect Python 3.12.x. feat(checker): Detect Python 3.12.x Feb 26, 2025
@captainreality
Copy link
Contributor Author

Looks like black has a formatting nit for you. You likely need to run black test/test_data/python.py and then check in and push the updated file to this PR.

Linter docs are here in case you haven't done this before: https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters

Oops, apologies for missing that. Format is now fixed.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's get this merged. I'm a little concerned we'll see false positives from it eventually if more people scan stuff with windows paths in it, but we'll deal with that if it happens later.

Thank you!

@terriko terriko merged commit 2f39df2 into intel:main Feb 28, 2025
24 checks passed
@captainreality captainreality deleted the add_python_312 branch February 28, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants