Skip to content

fix: Be flexible in zlib versions #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

qmfrederik
Copy link
Contributor

@qmfrederik qmfrederik commented Feb 1, 2025

  • Support versions with major.minor version number only
  • Support versions with more than one digit in the revision number

@qmfrederik qmfrederik force-pushed the fixes/zlib branch 2 times, most recently from 5e6ef5d to 799977a Compare February 14, 2025 10:01
@qmfrederik qmfrederik changed the title fix: Support zlib versions with major.minor version number only fix: Be flexible in zlib versions Feb 14, 2025
- Support versions with major.minor version number only
- Support versions with more than one digit in the revision number
@qmfrederik
Copy link
Contributor Author

@terriko I've fixed the test in this PR and rebased on main, but that will require you to re-approve the workflow.

@terriko
Copy link
Contributor

terriko commented Feb 20, 2025

@qmfrederik I've approved the workflow, and I've pinged my ops people to see if I can get you added to the list of people who can run workflows without me manually approving them. Assuming they agree, you should get an invite to a group with a really long name like intel_cve-bin-tool_tests or something in the next couple of days; please accept it if you'd like to be able to trigger github actions tests on your own!

@qmfrederik
Copy link
Contributor Author

Roger that, thanks @terriko !

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge time! And the ops folk tell me that the team name is cve-bin-tool-read so look out for that invitation soon now that I've got the request correct in their system.

@terriko terriko merged commit d14eb65 into intel:main Feb 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants