feat(checker): Add cairo #4740
Merged
feat(checker): Add cairo #4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
requested changes
Feb 11, 2025
test/test_data/cairo.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| # Copyright (C) 2022 Orange | |||
There was a problem hiding this comment.
You might want the copyright here to be Keysight as in the one above. I'll mark this as requiring changes so I don't merge it by mistake before you're ready.
There was a problem hiding this comment.
Good catch, thanks! I updated the copyright statement and rebased on main, should be good now.
qmfrederik
force-pushed
the
features/cairo
branch
from
95d923a to
50d9719
Compare
|
@terriko This fails on Testing / Tests that may fail due to network or HTML (pull_request) , but looks good otherwise? |
qmfrederik
force-pushed
the
features/cairo
branch
from
50d9719 to
2337d1f
Compare
terriko
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.