feat: add json2 schema and test #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aryan Bakliwal <[email protected]>
|
Hey @terriko @mastersans I've added the schema for JSON2 and validation test, could you please take a look and let me know the required changes. |
terriko
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
This looks good to me. I'm going to give @mastersans and @anthonyharrison a few more hours in case they want to chime in before I merge it, but after that I think it'll maker more sense to merge it and we can address any concerns in future PRs.
|
Okay, it's later and late enough per time zones that probably no one else will chime in today. I'm going to go ahead and merge. Thank you for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4324
Added JSON2 schema and a test that calls
jsonschema.validate