Skip to content

feat: auto detect for vex and added linkage check #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: auto detect for vex and added linkage check #4415

merged 4 commits into from
Sep 4, 2024

Conversation

mastersans
Copy link
Member

  • Enabled auto detection for vex
  • Added linkage check of cyclonedx vex and sbom using bom-link.

cc @anthonyharrison @terriko

terriko
terriko requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, I've just got some questions about whether we need to tighten up the input validation when the serial numbers are read.

@mastersans mastersans requested a review from terriko September 3, 2024 19:30
terriko
terriko approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's see how this works out -- if I'm wrong and invalid serial numbers are a common thing then we'll revisit.

@terriko terriko merged commit b893616 into intel:main Sep 4, 2024
21 checks passed
@mastersans mastersans deleted the auto-detect branch September 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mastersans @terriko