Skip to content

feat: improved triage process #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 8, 2024
Merged

feat: improved triage process #4279

merged 11 commits into from
Aug 8, 2024

Conversation

mastersans
Copy link
Member

@mastersans mastersans commented Jul 22, 2024

Improved Triage Process
tasklist for my tracking shouldn't take long to finish it up.

  • implement functionality to check linkage between sbom and vex(should be part of seprate PR)
  • take information for reason of updating vex from user to be used by lib4vex for updating the vex file
  • write test for functionality
  • remove older test related to the functionality
  • write documentation. (maybe a full page explaining triage and triaging process)

@mastersans
Copy link
Member Author

@terriko @anthonyharrison this PR is ready for review, and test regarding this PR is underway will add soon, also the currently failing test, ill fix in sepreate PR those are due to the cyclonedx vex test file being outdated after lib4sbom release, this PR also include some changes from #4160

@mastersans mastersans marked this pull request as ready for review July 29, 2024 04:32
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit around using Path instead of os.path below, also can you do the a minimaldocs change so that the argument is correct in https://github.com/intel/cve-bin-tool?tab=readme-ov-file#full-option-list and the similar conent in MANUAL.md? You can just fill in the same sentences you have currently in the help text into the appropriate stub sections in MANUAL.md. I know you're working on a bigger docs update but I just want to make sure we're not too out of sync while you work on the bigger tutorial and stuff.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on here but it looks like maybe a missing if statement for a key check?

 =========================== short test summary info ============================
FAILED test/test_output_engine.py::TestOutputEngine::test_output_file - KeyError: 'product'
FAILED test/test_output_engine.py::TestOutputEngine::test_output_file_filename_already_exists - KeyError: 'product'
FAILED test/test_output_engine.py::TestOutputEngine::test_output_file_incorrect_filename - KeyError: 'product'
FAILED test/test_output_engine.py::TestOutputEngine::test_output_file_wrapper - KeyError: 'product'

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. We'll need to double-check that the docs match the changed arguments, but I think that was going in a separate PR so I won't make you fit it in here.

Also, I don't think you want to do it for GSoC but we should maybe have a conversation about whether there's anything else out of our old triage system (the one that did time series data and stuff) that we want to rename or remove still.

@terriko terriko merged commit 436a203 into intel:main Aug 8, 2024
22 checks passed
@mastersans mastersans deleted the triage-process branch August 14, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants