Skip to content

feat: tempfile cleanup for RParser #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Conversation

joydeep049
Copy link
Contributor

Continuing my and @mastersans work, adding tempfile cleanup for all fuzzing scripts.
Will be working on this over the next few days.

@terriko @anthonyharrison

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (d6cbe40) to head (b7278cf).
Report is 106 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3944      +/-   ##
==========================================
+ Coverage   75.41%   80.84%   +5.43%     
==========================================
  Files         808      820      +12     
  Lines       11983    12358     +375     
  Branches     1598     1670      +72     
==========================================
+ Hits         9037     9991     +954     
+ Misses       2593     1936     -657     
- Partials      353      431      +78     
Flag Coverage Δ
longtests 75.86% <ø> (+0.45%) ⬆️
win-longtests 78.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I'm thinking I may have missed some things in the others that I'm noting here.

Co-authored-by: Terri Oda <[email protected]>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to merge, I'm going to open an issue about maybe changing some of the existing fuzzers to use longer prefixes on the temp dirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants