-
Notifications
You must be signed in to change notification settings - Fork 544
feat: tempfile cleanup for RParser #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes
Changes-2
Changes
Changes
Changes
Changes
Changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
+ Coverage 75.41% 80.84% +5.43%
==========================================
Files 808 820 +12
Lines 11983 12358 +375
Branches 1598 1670 +72
==========================================
+ Hits 9037 9991 +954
+ Misses 2593 1936 -657
- Partials 353 431 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I'm thinking I may have missed some things in the others that I'm noting here.
Co-authored-by: Terri Oda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough to merge, I'm going to open an issue about maybe changing some of the existing fuzzers to use longer prefixes on the temp dirs.
Continuing my and @mastersans work, adding tempfile cleanup for all fuzzing scripts.
Will be working on this over the next few days.
@terriko @anthonyharrison