Skip to content

chore: update pre-commit config #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore: update pre-commit config #3678

merged 2 commits into from
Jan 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2024

Automated changes by create-pull-request GitHub action

@terriko
Copy link
Contributor

terriko commented Jan 3, 2024

closing and re-opening for tests.

@terriko terriko closed this Jan 3, 2024
@terriko terriko reopened this Jan 3, 2024
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit 3.6.0 no longer supports python 3.8, so we need to adjust accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf9afe9) 78.98% compared to head (2bbaeea) 78.67%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
- Coverage   78.98%   78.67%   -0.31%     
==========================================
  Files         797      797              
  Lines       11927    11927              
  Branches     1602     1602              
==========================================
- Hits         9420     9384      -36     
- Misses       2075     2106      +31     
- Partials      432      437       +5     
Flag Coverage Δ
longtests 73.76% <ø> (-4.55%) ⬇️
win-longtests 76.72% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 3.6.0 issue and ready to merge.

@terriko terriko merged commit 520d314 into main Jan 4, 2024
inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 16, 2024
* chore: update pre-commit config

* fix: pre-commit 3.6.0 needs python > 3.8

---------

Co-authored-by: GitHub <[email protected]>
Co-authored-by: Terri Oda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants