fix: Deprecate NVD API 1.0 #3671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshatgokul
commented
Dec 25, 2023
akshatgokul
commented
- Resolves fix: Deprecate NVD API 1.0 #3582
- Updated documentation clarifying the failover to api2
akshatgokul
force-pushed
the
deprecate-api1
branch
from
22ad047 to
51fc5e8
Compare
|
Hi @terriko, can you please review this? Thanks! |
|
I've approved the workflow to run tests. I'll be back to review more carefully sometime after the tests all pass (but we're having some CI issues at the moment so that may not happen today). |
akshatgokul
force-pushed
the
deprecate-api1
branch
from
28133f7 to
31a33fd
Compare
|
I have fixed a small linting problem, and apparently 'failover' is not a recognized word by the dictionaries. |
terriko
requested changes
Dec 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3671 +/- ##
==========================================
+ Coverage 78.98% 79.24% +0.26%
==========================================
Files 797 797
Lines 11927 11930 +3
Branches 1602 1603 +1
==========================================
+ Hits 9420 9454 +34
+ Misses 2075 2041 -34
- Partials 432 435 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
approved these changes
Jan 3, 2024
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Terri Oda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.